-
Notifications
You must be signed in to change notification settings - Fork 20
add to gcc11-bullseye to workflows - [MOD-9529] #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #680 +/- ##
==========================================
+ Coverage 96.24% 96.27% +0.03%
==========================================
Files 112 112
Lines 6278 6278
==========================================
+ Hits 6042 6044 +2
+ Misses 236 234 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -49,6 +49,7 @@ jobs: | |||
- focal | |||
# - bionic | |||
- bullseye | |||
- bullseye-gcc11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should have both "regular" bullseye and gcc11 bullseye on every PR merge. If you believe we need to have both flows, than let's keep it only in nightly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. I wasnt sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You removed it from the required jobs in the merge queue, but it will still run (the workflow of Bullseye will always run both jobs) - so I believe you have it in a separate file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -8,3 +8,9 @@ jobs: | |||
with: | |||
container: debian:bullseye | |||
pre-checkout-script: apt-get update && apt-get -y install git | |||
|
|||
bullseye-gcc11: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment to the PR with a link to a successful run of this new job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test redisearch on debian-bullseye with gcc>10